Update defs to use Partial
instead of deprecated $Shape
#4438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codemod
$Shape
toPartial
in the definitions, after the deprecation of$Shape
: https://medium.com/flow-type/announcing-partial-required-flow-utility-types-catch-annotations-3a32f0bf2a20Sometimes however, when used in an input position, it could work better to turn
$Shape<T>
into$ReadOnly<Partial<T>>
rather thanPartial<T>
. I don't know this is the case, so if people have new issues with their defs after this codemod, they can try adding the$ReadOnly
and see if it works better.